Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better BMP support #163

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Better BMP support #163

merged 3 commits into from
Apr 5, 2024

Conversation

digizeph
Copy link
Member

@digizeph digizeph commented Apr 5, 2024

This PR adds support for more BMP data types and fixes parsing issues for Statistics Report type (see #162).

The code base should be in sync with IANA BMP code definitions: https://www.iana.org/assignments/bmp-parameters/bmp-parameters.xhtml

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 94.38202% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 93.05%. Comparing base (1b62da4) to head (46e9580).
Report is 1 commits behind head on main.

Files Patch % Lines
src/parser/bmp/messages/stats_report.rs 92.10% 6 Missing ⚠️
src/parser/bmp/messages/peer_down_notification.rs 92.10% 3 Missing ⚠️
src/parser/bmp/messages/peer_up_notification.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   93.04%   93.05%   +0.01%     
==========================================
  Files          65       65              
  Lines        8162     8304     +142     
==========================================
+ Hits         7594     7727     +133     
- Misses        568      577       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digizeph digizeph merged commit 51f8540 into main Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant