feat(tupaiaWeb): RN-1403: Export images from visuals #5911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcaiger
reviewed
Sep 20, 2024
| import { useDashboard } from '../../../Dashboard'; | ||
| import { useDownloadImages } from './useDownloadImages'; | ||
| import { ExportIconButton } from '../../../EnlargedDashboardItem'; | ||
| import { SmallAlert } from '@tupaia/ui-components'; |
There was a problem hiding this comment.
this should be above the local imports
tcaiger
reviewed
Sep 20, 2024
| images: ViewReport['data'], | ||
| ) => { | ||
| return useMutation( | ||
| ['images', projectCode, entityCode, dashboardCode, reportCode], |
There was a problem hiding this comment.
I don't think you really need a mutation key, right?
tcaiger
reviewed
Sep 20, 2024
| async () => { | ||
| return Promise.all( | ||
| images?.map(photo => { | ||
| return fetch(photo.value, { |
There was a problem hiding this comment.
Could we use async await syntax instead?
tcaiger
reviewed
Sep 20, 2024
| onSuccess: async fetchedImages => { | ||
| if (!fetchedImages?.length) return; | ||
| // if there is only one image, download it directly | ||
| if (fetchedImages.length === 1) { |
There was a problem hiding this comment.
nice idea just returning the file if there is just one download
merge: update branch with latest dev
merge: update branch with latest dev before testing
merge: update branch with latest dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-1403: Export images from visuals
Changes:
Screenshots: