tweak(tupaiaWeb): RN-1420: Use dashboard codes in URLs #5884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcaiger
reviewed
Sep 8, 2024
| project?.code === projectCode && | ||
| !activeDashboard; | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
It's a bonus to replace this but of code I reckon
tcaiger
reviewed
Sep 8, 2024
packages/tupaia-web/src/Routes.tsx
Outdated
| @@ -92,7 +134,7 @@ export const Routes = () => { | |||
| <Route path="/:projectCode/:entityCode" element={<ProjectPageDashboardRedirect />} /> | |||
|
|
|||
| {/* The Dashboard has to be rendered below the Map, otherwise the map will re-mount on route changes */} | |||
| <Route path={ROUTE_STRUCTURE} element={<Dashboard />} /> | |||
| <Route path={ROUTE_STRUCTURE} element={<DashboardNameToCodeRedirect />} /> | |||
There was a problem hiding this comment.
This is pretty minor but I was initially confused by the naming of DashboardNameToCodeRedirect as I didn't realise that it included the Dashboard component. Maybe it should be just called DashboardRoute or DashboardCodeRoute or something?
tcaiger
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-1420: Use dashboard codes in URLs
Changes:
dashboardNameto bedashboardCode