-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(security): RN-1303: Update password storage to use argon2 #5872
base: dev
Are you sure you want to change the base?
Conversation
packages/database/src/migrations/20240902224836-argon2-passwords-modifies-data.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this all checks out, nice work @tcaiger 🙏
packages/web-config-server/src/authSession/getUserFromAuthHeader.js
Outdated
Show resolved
Hide resolved
packages/central-server/src/apiV2/utilities/emailVerification.js
Outdated
Show resolved
Hide resolved
@rohan and @passcod thanks for the reviews. One more small question, do you think there is any value or need to keep track of which users have been migrated to the new algorithm on login? In case we ever wanted to remove the sha256EncryptPassword step on login. We could add a isMigrated flag or something?! |
oh because you try sha256 by fallback. standard password hashes look like this:
instead of using a fallback, we could do the migration such that it goes
then that both provides an early switch instead of a fallback logic, and keeps track of remaining oldhashed users |
Alternatively, set a new field sure |
Issue #: feat(security): RN-1303: Update password storage
Changes: