tweak(tupaiaWeb): RN-1383: Make raw data downloads use one time link #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcaiger
reviewed
Aug 22, 2024
| const PLATFORM_SETTINGS = { | ||
| tupaia: { | ||
| url: requireEnv('TUPAIA_WEB_SERVER_API_URL'), | ||
| friendlyName: 'Tupaia', |
There was a problem hiding this comment.
I like the term friendlyName :)
tcaiger
reviewed
Aug 22, 2024
| const { error, filePath } = responseBody; | ||
| const { platform } = req.query; | ||
| const subject = 'Your export from Tupaia'; |
There was a problem hiding this comment.
I wonder if the subject should change depending on the platform?
tcaiger
reviewed
Aug 22, 2024
| @@ -28,13 +17,13 @@ type ResponseBody = { | |||
|
|
|||
| type Req = { | |||
| query: { | |||
| emailExportFileMode?: EmailExportFileModes; | |||
| platform?: 'tupaia' | 'adminPanel' | 'datatrak'; | |||
There was a problem hiding this comment.
Should Lesmis be included as an option?
|
@tcaiger are you able to re-review this one? |
tcaiger
approved these changes
Sep 12, 2024
merge: update branch with latest dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-1383: Make raw data downloads use one time link
Changes:
constructExportEmailto handle links to different platformsgetTempDirectoryandgetExportPathForUsertoserver-utilsExportSurveyDataHandlerinweb-config-serveruse same temp directory as everywhere else