Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Bevy dependency repo Main branch & Reserve components for editor layout system #24

Merged
merged 13 commits into from
Sep 24, 2024

Conversation

Atlas16A
Copy link
Contributor

No description provided.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@rewin123
Copy link
Contributor

Since we now have milestones corresponding to the roadmap, I took the liberty of assigning a milestone to this PR. Feel free to change the assigned milestone, as I don't have authority here.

@rewin123 rewin123 added A-Panes Related to editor panel based workflow C-Dependencies A change to the crates that Bevy depends on labels Sep 23, 2024
Cargo.toml Outdated Show resolved Hide resolved
@alice-i-cecile
Copy link
Member

@BD103 we want to pin a specific commit for this, not just "main".

Cargo.toml Outdated Show resolved Hide resolved
@Atlas16A
Copy link
Contributor Author

CI is still failing but not sure why this time.

auto-merge was automatically disabled September 23, 2024 19:39

Head branch was pushed to by a user without write access

@BD103
Copy link
Member

BD103 commented Sep 23, 2024

Looks like you added bevy as a dependency of the main bevy_editor_prototypes, but not the bevy_panes sub-crate. Could you please move the bevy = { ... } line in Cargo.toml to be under a new [workspace.dependencies] table? (As shown here.) After that, please add bevy.workspace = true under [dependencies] of both Cargo.toml and bevy_panes/Cargo.toml.

By doing this, you add bevy as a dependency available to bevy_panes specifically. I chose to make bevy a workspace dependency so that you don't have to copy the commit hash everywhere, and so that upgrades are easier.

auto-merge was automatically disabled September 23, 2024 22:27

Head branch was pushed to by a user without write access

@BD103
Copy link
Member

BD103 commented Sep 24, 2024

Ok, we're almost there! (Don't worry!)

The (hopefully final) CI error is the missing documentation lint. For all items in bevy_panes (the add() function and the components), could you add a short doc description? Doc comments start in ///, and there are plenty examples around to base things on. Comments can be a single sentence, though feel free to go into further detail!

auto-merge was automatically disabled September 24, 2024 11:27

Head branch was pushed to by a user without write access

crates/bevy_panes/src/lib.rs Show resolved Hide resolved
crates/bevy_panes/src/lib.rs Show resolved Hide resolved
crates/bevy_panes/src/lib.rs Show resolved Hide resolved
crates/bevy_panes/src/lib.rs Show resolved Hide resolved
crates/bevy_panes/src/lib.rs Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 24, 2024
Merged via the queue into bevyengine:main with commit f2f7549 Sep 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Panes Related to editor panel based workflow C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants