Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The One True Search™ #1204

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

The One True Search™ #1204

wants to merge 37 commits into from
+336 −13

Conversation

SIGSTACKFAULT
Copy link
Contributor

@SIGSTACKFAULT SIGSTACKFAULT commented May 27, 2024 •
edited
Loading

Just barely works!

2024-05-26.21-56-04.mp4

in hindsight i have no clue why i left the inspector open.

TODO:

  • assimilate assets search
  • assimilate examples search
  • add keyboard shortcut
  • show preview snippet in results
  • prioritize the section of the site that you're currently in
  • show something in the empty search dialog
  • think of some other tips
  • make it look good in the mobile menu
    • minor rework of mobile menu styles; now uses a vertical flexbox.
  • add close button

I will accept MRs on the SIGSTACKFAULT:one-true-search branch.

@SIGSTACKFAULT
add search icon
17b12bb
@SIGSTACKFAULT
on second thought, hard-code the svg.
8ec4515
@SIGSTACKFAULT
add search button to top bar
46cc43c
@SIGSTACKFAULT
rename icon() to search_icon()
c3177d1
@SIGSTACKFAULT
styling i'm vaguely happy with
caa4430
@SIGSTACKFAULT
more stuff but still no script
a19fa34 
i don't have to write a real commit message because it's gonna get
squashed anyway
@SIGSTACKFAULT
some comments about when things are hidden
4fc633d
@SIGSTACKFAULT
add history and tip randomization
a3922fe
@SIGSTACKFAULT
set default language (required for build_search_index)
2f230d7
@SIGSTACKFAULT
sorta kinda working
5c5dfc9
@SIGSTACKFAULT
add ability to click out of the search dialog
ed06fe3
@SIGSTACKFAULT
rewrite time already
cbd6ef3 
declare search history out of scope
@SIGSTACKFAULT
aosdifpoaisdfm this will all be squashed anyway
e39198a
@SIGSTACKFAULT
use js modules
40241e8
@SIGSTACKFAULT
don't need the underscores anymore
e6db573
@SIGSTACKFAULT
working Fuse search except only with a Zola patch i wrote
5abc19b
@SIGSTACKFAULT
faffing about
4671eb7
@SIGSTACKFAULT
switch back to elastic so this can actually ship without waiting for …
31ed0a4 
…upstream
@SIGSTACKFAULT
move examples to the end
cc62b50
@SIGSTACKFAULT
deprioritize examples in a way that doesn't mess up the tab order
eb0318c
@alice-i-cecile alice-i-cecile added S-Waiting-On-Author C-Feature A new feature, making something new possible C-Webdev labels May 27, 2024
@SIGSTACKFAULT
Copy link
Contributor Author

SIGSTACKFAULT commented May 27, 2024 •
edited
Loading

based on absolutely nothing i decided to put the mobile menu search button above the switch
image

@SIGSTACKFAULT
Copy link
Contributor Author

waiting on zola#2382

@MyZeD
Copy link
Contributor

MyZeD commented Oct 8, 2024

What do you think about a Javascript search in the client, e.g. https://lunrjs.com/ or http://elasticlunr.com/.

In Zola it shouldn't be difficult to pre-generate a JSON and load it as soon as the cursor is on the search input.
You can do the same with the Javascript search library.

This means that this JSON would not always be loaded in the background, as you usually don't need it unless someone wants to use the search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-Feature A new feature, making something new possible C-Webdev D-Complex S-Waiting-On-Author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SIGSTACKFAULT @MyZeD @alice-i-cecile