[COMMENTAIRE] Ajout des mentions dans les commentaires #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaudMZN
force-pushed
the
front-commentaire-mention
branch
from
844fa30
to
4679c4d
Compare
fbezagu
force-pushed
the
front-commentaire-mention
branch
from
86a1dd3
to
f0e3e31
Compare
CadiChris
reviewed
Sep 19, 2024
svelte/lib/mesure/contenus/activites/ActiviteAjoutCommentaire.svelte
Outdated
Show resolved
Hide resolved
ThibaudMZN
force-pushed
the
front-commentaire-mention
branch
4 times, most recently
from
0c7d04c
to
c762b26
Compare
fbezagu
force-pushed
the
front-commentaire-mention
branch
from
c762b26
to
874089e
Compare
… dans la requête GET `/mesures` ... ce nonce va nous permettre d'utiliser une librairie externe `Svelte` qui nécessite la manipulation d'objet du DOM, ce qui est pour l'instant interdit par nos CSP.
... On ajoute dans le `vite.config` une définition pour le NODE_ENV car la librairie `tippy` l'utilise à tort
ThibaudMZN
force-pushed
the
front-commentaire-mention
branch
from
874089e
to
48ea412
Compare
... suite à une decision métier
fbezagu
force-pushed
the
front-commentaire-mention
branch
from
34022cc
to
a8e8715
Compare
...ce fonctionnement se rapproche beaucoup de celui de Discord
fbezagu
force-pushed
the
front-commentaire-mention
branch
from
2042a7c
to
aa3a8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ajoute ici la possibilité de faire des "Mentions" en utilisant la touche "@".
On utilise la librairie tiptap. On souhaiterai utiliser la librairie svelte-tiptap, mais elle n'est disponible que pour Svelte >= 4.
On a donc dû copier le code de la librairie qui fait le mapping entre TipTap et le composant Svelte.