Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getting incubator object using page.id #20873

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LucasCharrier
Copy link
Collaborator

@LucasCharrier LucasCharrier commented Nov 13, 2024

Incubator's identifier in site.incubators items is '/incubateurs/incubatorId', we need the "/incubateurs" string to be at in the id.

Modification des fiches

Attention, le contenu fiches startup, membre et incubateur n'est plus modifiable directement sur GitHub, tu dois exclusivement utiliser l'espace-membre.

Les changements sont publiés sur le site sous 24h max.

@LucasCharrier LucasCharrier changed the title fix: getting incubator object using page.id to have the prefix /incub… fix: getting incubator object using page.id Nov 14, 2024
Copy link
Contributor

@freesteph freesteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

petit nitpick des familles

{% unless incubator %}
{% assign incubator = site.incubators | find: "id", incubator_id %}
{% endunless %}
{% assign incubator = site.incubators | where:'id', page.id | first %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants