Merge v4.2.6 #53
Annotations
10 errors and 5 warnings
lint:
app/lib/formatter.rb#L21
[Correctable] Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://rubystyle.guide#if-as-a-modifier)
|
lint:
app/lib/formatter.rb#L22
Style/StringConcatenation: Prefer string interpolation to string concatenation. (https://rubystyle.guide#string-interpolation)
|
lint:
app/lib/formatter.rb#L55
[Correctable] Style/RegexpLiteral: Use %r around regular expression. (https://rubystyle.guide#percent-r)
|
lint:
app/lib/formatter.rb#L137
Style/OptionalBooleanParameter: Prefer keyword arguments for arguments with a boolean default value; use animate: false instead of animate = false. (https://rubystyle.guide#boolean-keyword-arguments)
|
lint:
app/lib/formatter.rb#L158
Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://rubystyle.guide#three-is-the-number-thou-shalt-count)
|
lint:
app/lib/formatter.rb#L164
Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://rubystyle.guide#three-is-the-number-thou-shalt-count)
|
lint:
app/lib/formatter.rb#L165
[Correctable] Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].
|
lint:
app/lib/formatter.rb#L210
[Correctable] Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].
|
lint:
app/lib/formatter.rb#L234
[Correctable] Style/CommentAnnotation: Annotation keywords like Note should be all upper case, followed by a colon, and a space, then a note describing the problem. (https://rubystyle.guide#annotate-keywords)
|
lint:
app/lib/formatter.rb#L289
[Correctable] Style/RegexpLiteral: Use %r around regular expression. (https://rubystyle.guide#percent-r)
|
lint:
app/lib/activitypub/activity/flag.rb#L44
Lint/DuplicateMethods: Method ActivityPub::Activity::Flag#report_comment is defined at both app/lib/activitypub/activity/flag.rb:40 and app/lib/activitypub/activity/flag.rb:44.
|
lint:
app/lib/formatter.rb#L133
[Correctable] Lint/ElseLayout: Odd else layout detected. Did you mean to use elsif?
|
lint:
app/lib/formatter.rb#L229
[Correctable] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
|
lint:
app/mailers/application_mailer.rb#L24
Lint/DuplicateMethods: Method ApplicationMailer#set_autoreply_headers! is defined at both app/mailers/application_mailer.rb:18 and app/mailers/application_mailer.rb:24.
|
lint:
app/models/webhook.rb#L91
Lint/DuplicateMethods: Method Webhook#validate_permissions is defined at both app/models/webhook.rb:76 and app/models/webhook.rb:91.
|