Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Preview Pane for Block Math #29

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

benrbray
Copy link
Owner

@benrbray benrbray commented Aug 23, 2021

Resolves #28.

  • Display math now shows a preview pane. Inline math previews may be supported in the future.
  • It should be fairly simple to adjust the appearance of the preview pane with CSS.
  • Added an initialText parameter to insertMathCmd

Breaking Changes

  • Added new isBlockMath argument to MathView constructor
  • mathPlugin and mathPluginSpec are now functions that accept an options parameter
  • The mathPlugin state now has an extra flag indicating whether previews are enabled

TODOs:

  • Investigate whether inline previews can be trivially added (e.g. via CSS) or whether they should be added in a separate PR.
  • Update the docs site with a checkbox to enable/disable previews?
  • Better error reporting when preview is active?

@benrbray benrbray added the enhancement New feature or request label Aug 23, 2021
@Saul-Mirone
Copy link
Contributor

I think it's better to have the inline previews in a separate PR, since there's no common things with block preview IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview panel support
2 participants