Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add boolean operations (overlays) #62

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ endif()

add_library(spherely MODULE
src/accessors-geog.cpp
src/boolean-operations.cpp
src/creation.cpp
src/geography.cpp
src/io.cpp
Expand Down
102 changes: 102 additions & 0 deletions src/boolean-operations.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
#include <s2geography.h>
#include <s2geography/geography.h>

#include "constants.hpp"
#include "creation.hpp"
#include "geography.hpp"
#include "pybind11.hpp"

namespace py = pybind11;
namespace s2geog = s2geography;
using namespace spherely;

class BooleanOp {
public:
BooleanOp(S2BooleanOperation::OpType op_type)
: m_op_type(op_type), m_options(s2geog::GlobalOptions()) {
// TODO make this configurable
// m_options.polyline_layer_action = s2geography::GlobalOptions::OUTPUT_ACTION_IGNORE;
}

PyObjectGeography operator()(PyObjectGeography a, PyObjectGeography b) const {
const auto& a_index = a.as_geog_ptr()->geog_index();
const auto& b_index = b.as_geog_ptr()->geog_index();
std::unique_ptr<s2geog::Geography> geog_out =
s2geog::s2_boolean_operation(a_index, b_index, m_op_type, m_options);

return make_py_geography(std::move(geog_out));
}

private:
S2BooleanOperation::OpType m_op_type;
s2geog::GlobalOptions m_options;
};

// PyObjectGeography intersection(PyObjectGeography a, PyObjectGeography b) {
// const auto& a_index = a.as_geog_ptr()->geog_index();
// const auto& b_index = b.as_geog_ptr()->geog_index();

// std::unique_ptr<s2geog::Geography> geog_out = s2geog::s2_boolean_operation(
// a_index, b_index, S2BooleanOperation::OpType::INTERSECTION,
// s2geog::GlobalOptions());

// return make_py_geography(std::move(geog_out));
// }

void init_boolean_operations(py::module& m) {
m.def("union",
py::vectorize(BooleanOp(S2BooleanOperation::OpType::UNION)),
py::arg("a"),
py::arg("b"),
R"pbdoc(
Computes the union of both geographies.

Parameters
----------
a, b : :py:class:`Geography` or array_like
Geography object

)pbdoc");

m.def("intersection",
py::vectorize(BooleanOp(S2BooleanOperation::OpType::INTERSECTION)),
py::arg("a"),
py::arg("b"),
R"pbdoc(
Computes the intersection of both geographies.

Parameters
----------
a, b : :py:class:`Geography` or array_like
Geography object

)pbdoc");

m.def("difference",
py::vectorize(BooleanOp(S2BooleanOperation::OpType::DIFFERENCE)),
py::arg("a"),
py::arg("b"),
R"pbdoc(
Computes the difference of both geographies.

Parameters
----------
a, b : :py:class:`Geography` or array_like
Geography object

)pbdoc");

m.def("symmetric_difference",
py::vectorize(BooleanOp(S2BooleanOperation::OpType::SYMMETRIC_DIFFERENCE)),
py::arg("a"),
py::arg("b"),
R"pbdoc(
Computes the difference of both geographies.

Parameters
----------
a, b : :py:class:`Geography` or array_like
Geography object

)pbdoc");
}
2 changes: 2 additions & 0 deletions src/spherely.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace py = pybind11;
void init_geography(py::module&);
void init_creation(py::module&);
void init_predicates(py::module&);
void init_boolean_operations(py::module&);
void init_accessors(py::module&);
void init_io(py::module&);

Expand All @@ -23,6 +24,7 @@ PYBIND11_MODULE(spherely, m) {
init_geography(m);
init_creation(m);
init_predicates(m);
init_boolean_operations(m);
init_accessors(m);
init_io(m);

Expand Down
Loading