Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_x and get_y vectorized functions (Point-only) #37

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jorisvandenbossche
Copy link
Collaborator

Awaiting a more complex function to get coordinates in general, adding a simple get_lng/get_lat functions just for points (so those can easily be vectorized)

@jorisvandenbossche
Copy link
Collaborator Author

I see that R's s2 (based on bigquery?) still calls this st_x and st_y, so should we also use get_x and get_y here?

@martinfleis
Copy link
Contributor

should we also use get_x and get_y here?

+1 on that as that is also consistent with shapely.

@jorisvandenbossche jorisvandenbossche changed the title Add get_lat and get_lng vectorized functions (Point-only) Add get_x and get_y vectorized functions (Point-only) Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants