Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: build sdist and wheels (Linux & MacOS) #35

Merged
merged 44 commits into from
Aug 21, 2024
Merged

CI: build sdist and wheels (Linux & MacOS) #35

merged 44 commits into from
Aug 21, 2024

Conversation

benbovy
Copy link
Owner

@benbovy benbovy commented Aug 19, 2024

No description provided.

@benbovy benbovy mentioned this pull request Aug 20, 2024
Merged
@jorisvandenbossche
Copy link
Collaborator

BTW, if you update

spherely/pyproject.toml

Line 21 in 38d3bf9

requires-python = ">=3.7"

to >=3.10 then it should autmatically limit the wheels to those python versions (not that it will the error, but I just noticed it was building and testing a python 3.7 wheel, and we don't really need to provide wheels for that many python versions)

I bumped testing to use Python 3.10+ (#36), so matching our requirements to that might be best.

@benbovy
Copy link
Owner Author

benbovy commented Aug 20, 2024 

libssl.3.dylib has a minimum target of 13.0

Looks like we'll need to build and install openssl manually on macos :-/

@jorisvandenbossche
Copy link
Collaborator 

libssl.3.dylib has a minimum target of 13.0

Looks like we'll need to build and install openssl manually on macos :-/

Could also (or at least for now) bump the deployment target (it just means the wheels are only installable on recent macos)

benbovy and others added 2 commits August 21, 2024 10:28
@benbovy
bump macos deployment target
07df1bc 
Unfortunately we cannot set lower target versions until we use an
alternative way to install openssl (e.g., build it from source). OpenSSL
Homebrew packages were built with higher target versions.
@benbovy @jorisvandenbossche
fix pytest command?
dce651c 
Co-authored-by: Joris Van den Bossche <[email protected]>
@jorisvandenbossche
Copy link
Collaborator

Success! Will have to add an upload step now to further verify that it actually works

@benbovy
Copy link
Owner Author

benbovy commented Aug 21, 2024

Success!

Yes finally!

We'll need to add windows too (maybe in a follow-up PR).

@benbovy
Copy link
Owner Author

benbovy commented Aug 21, 2024

We'll also need to include the licenses of the dependencies in the wheels.

@benbovy benbovy changed the title CI: build wheels CI: build sdist and wheels (Linux & MacOS) Aug 21, 2024
@benbovy
Copy link
Owner Author

benbovy commented Aug 21, 2024

Everything is green! I'm going to merge this PR now and release 0.0.1 so we can test if all the files are correctly uploaded to pypi. I'm also going to submit a PR to conda-forge/staged-recipes.

@benbovy benbovy merged commit fb658d0 into main Aug 21, 2024
20 checks passed
@benbovy benbovy deleted the python-wheels-ci branch August 21, 2024 13:41
@jorisvandenbossche
Copy link
Collaborator

Great!

@jorisvandenbossche jorisvandenbossche mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benbovy @jorisvandenbossche