Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REM] beesdoo_shift : dependency to beesdoo_base #314

Merged
merged 1 commit into from
May 17, 2022

Conversation

robinkeunen
Copy link
Member

Remove dependency introduced here : #297

@robinkeunen
Copy link
Member Author

Extract member card module will be done later (focusing on vertical-cooperative), it is listed here : coopiteasy/vertical-cooperative#204

Copy link
Collaborator

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robinkeunen
Copy link
Member Author

@polchampion c'est ici, sur la PR que j'aurai besoin d'un pouce vert plutot que sur l'issue. Pour tester : scanner des codes barres de partner sur la feuille de présence d'un shift.

@carmenbianca carmenbianca force-pushed the 12.0-beesdoo-shift-remove-dependency branch from ee2f5b8 to 72771f1 Compare March 15, 2022 13:35
@victor-champonnois
Copy link
Member

@polchampion I don't remember where we are on this, is it OK to merge ?

@victor-champonnois victor-champonnois merged commit 4af9c7d into 12.0 May 17, 2022
@victor-champonnois victor-champonnois deleted the 12.0-beesdoo-shift-remove-dependency branch May 17, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants