Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sort if query string q is set #1185

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

didoda
Copy link
Member

@didoda didoda commented Sep 26, 2024

This provides a fix on sort query param.
When search by q=... is performed, search engine is responsible for sorting, so sort= is not passed to API get call.

@didoda didoda added bug Something isn't working release:patch labels Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (34136ac) to head (3973c8f).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1185   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
- Complexity     1309     1310    +1     
=========================================
  Files            97       97           
  Lines          5016     5021    +5     
=========================================
+ Hits           5001     5006    +5     
  Misses           15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda changed the title Fix query sort Remove sort if query string q is set Sep 26, 2024
@didoda didoda added this to the 4.x milestone Sep 26, 2024
@didoda didoda merged commit d667046 into bedita:master Sep 26, 2024
14 checks passed
@didoda didoda deleted the fix/query-sort branch September 26, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant