Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize tree loading #1094

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Optimize tree loading #1094

merged 5 commits into from
Mar 19, 2024

Conversation

didoda
Copy link
Member

@didoda didoda commented Mar 19, 2024

This provides an optimization on tree load data in 2 ways: performance (using cache and reducing total calls number) and UI.

This introduces 3 endpoints (that internally use cache):

  • GET /tree/node/{id} (cache key is tree-node-<id>)
  • GET /tree/parent/{id} (cache key is tree-parent-<id>)
  • GET /tree/parents/{type}/{id} (cache key is tree-parents-<id>-<type>)

In UI, we have a message that tells what exactly it's loading in that moment: the user knows what's going on.

@didoda didoda added this to the 4.x milestone Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (2e94951) to head (2ae73af).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1094   +/-   ##
=========================================
  Coverage     99.68%   99.68%           
- Complexity     1186     1200   +14     
=========================================
  Files            93       93           
  Lines          4688     4782   +94     
=========================================
+ Hits           4673     4767   +94     
  Misses           15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda merged commit 7f54b77 into bedita:master Mar 19, 2024
22 checks passed
@didoda didoda deleted the feat/tree-optimize branch March 19, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant