Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use concrete object types in side Panel #1077

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

didoda
Copy link
Member

@didoda didoda commented Jan 18, 2024

This provides a refactor to use concrete object types in object view side panel, when you open it (on "add objects" button click, for a relation, for example).

This also updates placeholders plugin to provide proper "available types" when you try to add placeholder and side panel opens.

@didoda didoda added feature New feature or request refactor Code refactoring release:patch labels Jan 18, 2024
@didoda didoda added this to the 4.x milestone Jan 18, 2024
src/Utility/Schema.php Outdated Show resolved Hide resolved
src/View/Helper/SchemaHelper.php Show resolved Hide resolved
@didoda didoda requested a review from batopa January 18, 2024 12:57
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7769f7a) 99.67% compared to head (6effabd) 99.67%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1077   +/-   ##
=========================================
  Coverage     99.67%   99.67%           
  Complexity     1166     1166           
=========================================
  Files            91       91           
  Lines          4601     4603    +2     
=========================================
+ Hits           4586     4588    +2     
  Misses           15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paolosantarsiero paolosantarsiero self-assigned this Jan 25, 2024
@didoda didoda merged commit 98a0dbb into bedita:master Jan 25, 2024
22 checks passed
@didoda didoda deleted the refactor/use-concrete-object-types branch January 25, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor Code refactoring release:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants