Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ignoring files based on what git ignores #94

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

willcl-ark
Copy link
Contributor

Using the --gitignore option will ignore all *.md and *.html files which are ignored by git.

This is via a call to git ls-files --ignored --others --exclude-standard, then filtered for *.md and *.html.

Copy link
Owner

@becheran becheran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thanks for the PR. Very clever by using 'git' itself. Sorry for the rather late review. Don't find too much time lately.

I would merge it with some minor changes as seen in the comments.

src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Using this option will ignore all *.md and *.html files which are
currently ignored by git.

This is via `git ls-files --ignored --others --exclude-standard`.
@willcl-ark
Copy link
Contributor Author

Rebased to fix merge conflicts

@willcl-ark willcl-ark requested a review from becheran June 25, 2024 19:48
Copy link
Owner

@becheran becheran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks for the changes

@becheran becheran merged commit 4dcc559 into becheran:master Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants