Do Not Warn for Redirects to Given Patterns #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mutes warnings caused by redirections which lead to an url matching the given patterns.
|
I am confused, are the failing actions my fault? If so, I am really sorry - I can (locally) only test on Linux and do not really understand how the errors should be caused by my changes. |
|
Thanks for the PR. I don't know yet why it is failing on Windows. Will give it a try localy on Windows machine. |
|
CI is broken, but it is not because of this PR. Will merge and fix seperately. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #84, this adds the new option
--do-not-warn-for-redirect-towhich allows to mute warnings for redirections if they lead to an URL which matches the specified pattern.I've used my (rudimentary) understanding of Rust to implement this option roughly mirrored to the existing
--ignore-linksoption, so feel free to suggest any kind of improvements/problems which my solution has (I hope my choice of usingArcto share thedo_not_warn_for_redirect_tovector was at least not an utter failure)!The PR includes three new tests for
check_httpand adds the option to the main Readme.For now, I haven't changed the CHANGELOG.md because I am not sure if I am even supposed to do that.