pwm.c: do not unexport channels #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel complains that the PWM is not stopped ahead of being unexported. This may or may not be the case, but in any case, this helps avoid the kernel issue. Fixes beagleboard#154
|
If i remember correctly the reason I unexported the channels is because the pwm frequency can only be set once after export. Without the unexport the board would need to reboot to change PWM frequency. |
|
So finally, the channels have to be unexported right as per @StrawsonDesign ? Can someone provide clarity as to what is the status with this issue? |
|
The library should be fixed to export/unexport as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel complains that the PWM is not stopped ahead of being
unexported. This may or may not be the case, but in any case,
this helps avoid the kernel issue.
Fixes #154