Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comms cape overlay #175

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lorforlinux
Copy link

@RobertCNelson Hi,
I have updated this overlay with sink nodes and it's using the new format of DT now :)
Everything has been tested on BBBWL

Copy link
Member

@jadonk jadonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few extra comments would be great.

/* identification */
part-number = "BBORG_COMMS";
version = "00A2";
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something wrong with your tabs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, It seems like that. Everything looks good with vscode but not here :(

&am33xx_pinmux {
bborg_comms_can_pins: pinmux_comms_can_pins {
pinctrl-single,pins = <
BONE_P9_24 (PIN_INPUT_PULLUP | MUX_MODE2) /* P9_24: uart1_txd.d_can1_rx */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this eventually be an include of the virtual cape?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what do you mean by that. This overlay and the servo cape overlay will be updated to use the new bone bus type format as soon as I test the I2C buses on BBB and BBAI (same binary).

status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&bborg_comms_rs485_pins>;
//rs485-rts-delay = <0 0>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't these need to be enabled? When should they?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess when you need Request To Send (RTS) signal.

BONE_P9_11 (PIN_INPUT | MUX_MODE6) /* P9_11: gpmc_wait0.uart4_rxd_mux2 */
>;
};
sink@1 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the udev rules good to enable these?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RS585 seems to be working fine, I have not tested CAN with my MCP2515 CAN module yet. Is there something special with these to require special treatment from udev rules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants