Readonly ledger support #1412
Merged
Readonly ledger support #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment URLs ready for review. |
loneil
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Not seeing a difference between the read-only candy-prod ledger and the ones with endorsers
I see the ledger settings have is_write and read_only which is confusing (maybe worth confirming what those 2 things are?).... but in our setups we're not able to connect or write to the candy-prod one so should be marking that one as read only, and hiding that connect button.
Let's have the column be something other than the pencil icon with a different color too (accessibility etc). Maybe a check/X for "writable" unless anyone has a better UI idea
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
loneil
force-pushed
the
readonly-ledger-support
branch
from
6fa263f
to
4cb2640
Compare
loneil
reviewed
Oct 29, 2024
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
loneil
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1296