Fix for SSO Login Issue #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
WadeBarnes
commented
Sep 11, 2024
WadeBarnes
commented
- Refactor BuildUrlString to use UriBuilder to generate complete URL …
- Updated callers to reference the new function signature
- Added unit tests and Bogus library to make it easier to generate random test data
…format - Updated callers to reference the new function signature - Added unit tests and Bogus library to make it easier to generate random test data
|
Integrate the fix for the SSO Login issue from JASPER (bcgov#20) into SCV. |
|
This works for me locally. @sturufous, please give a quick test, you'll need to rebuild your local images ( |
10 tasks
|
@WadeBarnes I grabbed the code from the pull request and spun up an SCV instance in Docker locally. I was able to log in using my IDIR and the application appears to be working normally. Is that sufficient of a test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.