Fix for SSO Login Issue #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sturufous
reviewed
Sep 19, 2024
api/helpers/XForwardedForHelper.cs
Outdated
| namespace SS.Api.helpers | ||
| using System; | ||
|
|
||
| namespace Scv.Api.Helpers |
There was a problem hiding this comment.
Yup, copy paste error.
sturufous
reviewed
Sep 19, 2024
| }; | ||
|
|
||
| var portComponent = | ||
| string.IsNullOrEmpty(forwardedPort) || forwardedPort == "80" || forwardedPort == "443" |
There was a problem hiding this comment.
I added port 8080 here for scv to support running on Emerald.
There was a problem hiding this comment.
Purposely not doing that to keep things as similar to what's in prod silver now.
…rmat - Updated callers to reference the new function signature - Added unit tests and Bogus library to make it easier to generate random test data - From bcgov/jasper#20 Signed-off-by: Wade Barnes <[email protected]>
sturufous
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor BuildUrlString to use UriBuilder to generate complete URL fo…
Updated callers to reference the new function signature
Added unit tests and Bogus library to make it easier to generate random test data
From Fix for SSO Login Issue jasper#20