-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions, Dockerfiles and changes needed for Emerald #242
Conversation
@GeorgeWalker, Have you setup the GitHub secrets required for the workflows? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couple small recommendations below. In addition, could you provide some documentation around the updated CI/CD process (could be point form), enough for someone to understand what needs to happen to build and deploy updated code.
Also, would you be able to provide your thoughts around the pros and cons of migrating the api
and web
builds from s2i
builds to docker
builds.
The current builds defined in bcgov/sheriff-scheduling-configurations are s2i
based builds. That process can be performed in GitHub actions using redhat-actions/s2i-build. You can find examples of how to use it here; https://github.com/bcgov/dts-endorser-service/pull/37/files
Co-authored-by: Wade Barnes <[email protected]>
Co-authored-by: Wade Barnes <[email protected]>
No description provided.