Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions, Dockerfiles and changes needed for Emerald #242

Merged
merged 43 commits into from
Oct 23, 2024

Conversation

GeorgeWalker
Copy link
Contributor

No description provided.

@GeorgeWalker GeorgeWalker marked this pull request as draft July 3, 2024 21:23
@GeorgeWalker GeorgeWalker marked this pull request as ready for review July 3, 2024 22:11
@WadeBarnes
Copy link
Member

@GeorgeWalker, Have you setup the GitHub secrets required for the workflows?

Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couple small recommendations below. In addition, could you provide some documentation around the updated CI/CD process (could be point form), enough for someone to understand what needs to happen to build and deploy updated code.

Also, would you be able to provide your thoughts around the pros and cons of migrating the api and web builds from s2i builds to docker builds.

The current builds defined in bcgov/sheriff-scheduling-configurations are s2i based builds. That process can be performed in GitHub actions using redhat-actions/s2i-build. You can find examples of how to use it here; https://github.com/bcgov/dts-endorser-service/pull/37/files

.github/workflows/backup.yaml Outdated Show resolved Hide resolved
.github/workflows/backup.yaml Outdated Show resolved Hide resolved
@GeorgeWalker GeorgeWalker merged commit 736a90b into bcgov:master Oct 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants