Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17529 - Remove isPremium check from CSV export. #1235

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Sep 6, 2023

Issue #:
bcgov/entity#17529

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1235 (d6a4c12) into main (28ff797) will increase coverage by 2.24%.
Report is 84 commits behind head on main.
The diff coverage is 88.76%.

@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
+ Coverage   91.54%   93.78%   +2.24%     
==========================================
  Files         153      129      -24     
  Lines        9842     8563    -1279     
==========================================
- Hits         9010     8031     -979     
+ Misses        832      532     -300     
Flag Coverage Δ
eventlistenerqueue ?
payapi 93.78% <88.76%> (-0.12%) ⬇️
paymentjobs ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pay-api/src/pay_api/services/fee_schedule.py 99.53% <ø> (-0.01%) ⬇️
pay-api/src/pay_api/services/bcol_service.py 86.13% <61.53%> (-2.10%) ⬇️
...ay-api/src/pay_api/services/gcp_queue_publisher.py 64.70% <64.70%> (ø)
pay-api/src/pay_api/resources/account.py 92.47% <81.81%> (-0.97%) ⬇️
pay-api/src/pay_api/models/payment.py 95.87% <83.33%> (-0.40%) ⬇️
...ay-api/src/pay_api/services/base_payment_system.py 95.94% <85.71%> (-0.56%) ⬇️
pay-api/src/pay_api/utils/util.py 90.76% <87.50%> (-0.77%) ⬇️
pay-api/src/pay_api/services/invoice.py 96.79% <90.90%> (-0.23%) ⬇️
pay-api/src/pay_api/config.py 99.35% <100.00%> (+0.01%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
... and 45 more

... and 31 files with indirect coverage changes

@seeker25 seeker25 merged commit 4dc3fd0 into bcgov:main Sep 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants