Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22468 - Launch Tiles #3134

Merged
merged 3 commits into from
Nov 1, 2024
Merged

22468 - Launch Tiles #3134

merged 3 commits into from
Nov 1, 2024

Conversation

cameron-eyds
Copy link
Collaborator

Issue #:
bcgov/entity#22468

Notes:

  • Requires the addition of feature flag: enable-drs-lookup to whichever LD space manages auth-web
  • Adds env/env.example and vaults properties for document service url
  • *this may require the property to be added if the vault properties are not shared between projects

Description of changes:

  • Creates common component launch tile for basic feature routing or external connections (ie an action or href)
  • Refactors Involuntary Dissolution tile to a configuration (and adds Document Record Service config)
  • Unit testing for common component
  • Linting / Spacing fixes
Screenshot 2024-10-31 at 8 26 31 AM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Oct 31, 2024
@bcgov bcgov deleted a comment from sonarcloud bot Oct 31, 2024
@bcgov bcgov deleted a comment from sonarcloud bot Oct 31, 2024
@bcgov bcgov deleted a comment from bcregistry-sre Oct 31, 2024
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@cameron-eyds
Copy link
Collaborator Author

Not sure about this, didn't like it used directly from prop, so tried computing it via the prop.
Either way, the url is provided and computed from local configuration / env variables, not sure what more we can do to sanitize, open to suggestions!

Screenshot 2024-10-31 at 9 21 29 AM

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3134-8p6hibgx.web.app

@bcgov bcgov deleted a comment from bcregistry-sre Oct 31, 2024
@seeker25
Copy link
Collaborator

seeker25 commented Oct 31, 2024

@cameron-eyds can you put the ticket number in the title please? we have an automated release script that picks these up and tags them in zenhub

https://github.com/bcgov/sbc-pay/blob/main/releases/release_to_zenhub_auth.py

@seeker25
Copy link
Collaborator

seeker25 commented Oct 31, 2024

Not sure about this, didn't like it used directly from prop, so tried computing it via the prop. Either way, the url is provided and computed from local configuration / env variables, not sure what more we can do to sanitize, open to suggestions!

Screenshot 2024-10-31 at 9 21 29 AM

I think there is a sanitize library we're already using

I just logged in and ignored

@cameron-eyds cameron-eyds changed the title Launch Tiles 22468 - Launch Tiles Oct 31, 2024
@cameron-eyds
Copy link
Collaborator Author

@cameron-eyds can you put the ticket number in the title please? we have an automated release script that picks these up and tags them in zenhub

https://github.com/bcgov/sbc-pay/blob/main/releases/release_to_zenhub_auth.py

Absolutely, thank you!

Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if I should create the flag in LD, or if you'll handle this one

also need secrets in 1pass

@cameron-eyds
Copy link
Collaborator Author

Let me know if I should create the flag in LD, or if you'll handle this one

also need secrets in 1pass

@seeker25
Yes please, thank you!
I don't have LD admin access, that would awesome.
If you could set to true in DEV and false for TEST/PROD

@seeker25
Copy link
Collaborator

Tomorrow we'll get this sorted

@cameron-eyds
Copy link
Collaborator Author

Tomorrow we'll get this sorted

No rush whatsoever, whenever works!

@seeker25 seeker25 merged commit e2c466d into bcgov:main Nov 1, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants