Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23152 - partial refunds fixes / updates #3116

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Oct 23, 2024

Issue #:
bcgov/entity#23152

Description of changes:

  • updates / fixes to partial refunds OPS UI

  • Information text describing partial refund table and partial refund summary

  • show original line item amounts per fee

  • resolve payload generation issues with incorrect fee type and amounts

  • fix clearing form and validations when fetching invoice

  • Message for unsupported invoice for partial refund
    Screenshot 2024-10-23 at 2 00 21 PM

  • Field validation when exceeding the original line item amount and row validation for action button disabling
    Screenshot 2024-10-23 at 2 01 00 PM

  • Add review summary table to indicate refund amounts per line item and disable the original row
    Screenshot 2024-10-23 at 2 05 23 PM

  • Fix multi line item support
    Screenshot 2024-10-23 at 2 06 11 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@ochiu
Copy link
Collaborator Author

ochiu commented Oct 23, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3116-6b4azfcv.web.app

@seeker25
Copy link
Collaborator

Looks great Ody!

Copy link

sonarcloud bot commented Oct 24, 2024

@ochiu ochiu marked this pull request as ready for review October 24, 2024 20:05
@ochiu ochiu merged commit 5f86ad7 into bcgov:main Oct 24, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants