-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
23647 - Update Continuation Authorization Staff Review #3088
23647 - Update Continuation Authorization Staff Review #3088
Conversation
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
<v-card | ||
id="continuation-authorization-review-result-vcard" | ||
flat | ||
class="mt-6" | ||
> | ||
<CardHeader | ||
icon="mdi-stamper" | ||
label="Authorization Review" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This UI uses an older version of MDI fonts. Is mdi-approval
one of the available icons?
I've also asked Jacqueline for help with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! mdi-approval is not available now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any update on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this icon is not available now. I didn't find mdi-approval in current or previous version. May I have suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you have now looks OK (even though it looks more like a paint brush than a stamper, haha), but it's up to the UI/UX team to approve this..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha. Sure, then I will keep this mdi-stamper for now and put a note in the ticket for the UI/UX team to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auth-web/src/components/auth/staff/continuation-application/AuthorizationContactInformation.vue
Show resolved
Hide resolved
/gcbrun |
Temporary Url for review: https://bcregistry-account-dev--pr-3088-qqpochtk.web.app |
auth-web/src/components/auth/staff/continuation-application/AuthorizationContactInformation.vue
Outdated
Show resolved
Hide resolved
auth-web/src/components/auth/staff/continuation-application/HomeJurisdictionInformation.vue
Outdated
Show resolved
Hide resolved
auth-web/src/components/auth/staff/continuation-application/HomeJurisdictionInformation.vue
Outdated
Show resolved
Hide resolved
auth-web/src/components/auth/staff/continuation-application/HomeJurisdictionInformation.vue
Outdated
Show resolved
Hide resolved
auth-web/src/components/auth/staff/continuation-application/HomeJurisdictionInformation.vue
Show resolved
Hide resolved
auth-web/src/components/auth/staff/continuation-application/AuthorizationContactInformation.vue
Show resolved
Hide resolved
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please wait for Ketaki's review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Arwen! Looks good to me
@severinbeauvais Hi Severin, could you please merge it? Thanks! |
Issue #:
bcgov/entity#23647
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).