Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23647 - Update Continuation Authorization Staff Review #3088

Conversation

ArwenQin
Copy link
Contributor

@ArwenQin ArwenQin commented Oct 22, 2024

Issue #:
bcgov/entity#23647

Description of changes:

  • Update Continuation Authorization Staff Review page per new UI Design
  • Updated language, labels, header and icon
  • Added Unlimited Liability Corporation Information section
  • Added Contact Information section

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

<v-card
id="continuation-authorization-review-result-vcard"
flat
class="mt-6"
>
<CardHeader
icon="mdi-stamper"
label="Authorization Review"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per UI Design, we need this icon here:
image

I didn't find this one in MDI, could you please suggest? Thanks a lot

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This UI uses an older version of MDI fonts. Is mdi-approval one of the available icons?

I've also asked Jacqueline for help with this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! mdi-approval is not available now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this icon is not available now. I didn't find mdi-approval in current or previous version. May I have suggestions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you have now looks OK (even though it looks more like a paint brush than a stamper, haha), but it's up to the UI/UX team to approve this..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha. Sure, then I will keep this mdi-stamper for now and put a note in the ticket for the UI/UX team to review.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArwenQin
Copy link
Contributor Author

ArwenQin commented Oct 22, 2024

Main changes preview:
New section - Unlimited Liability Corporation Information section and Contact Information section
image

@severinbeauvais
Copy link
Collaborator

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3088-qqpochtk.web.app

Copy link

sonarcloud bot commented Oct 22, 2024

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for Ketaki's review.

Copy link
Collaborator

@ketaki-deodhar ketaki-deodhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Arwen! Looks good to me

@ArwenQin
Copy link
Contributor Author

@severinbeauvais
Jacqueline updated the design to use the current stamper icon:
image

Hi Severin, could you please merge it? Thanks!

@severinbeauvais severinbeauvais merged commit 54de24d into bcgov:main Oct 23, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants