Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21536 - Approval/rejection review #3079

Merged
merged 23 commits into from
Oct 21, 2024

Conversation

rodrigo-barraza
Copy link
Collaborator

Issue #:
bcgov/entity#21536

Description of changes:
Adding the ability of an expense authority to approve or decline short name refunds.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@ochiu
Copy link
Collaborator

ochiu commented Oct 16, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3079-acknmxx2.web.app

@seeker25 seeker25 marked this pull request as draft October 16, 2024 21:27
@rodrigo-barraza rodrigo-barraza marked this pull request as ready for review October 18, 2024 15:22
@seeker25
Copy link
Collaborator

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3079-acknmxx2.web.app

@seeker25
Copy link
Collaborator

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3079-acknmxx2.web.app

@ochiu
Copy link
Collaborator

ochiu commented Oct 18, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3079-acknmxx2.web.app

@ochiu
Copy link
Collaborator

ochiu commented Oct 18, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3079-acknmxx2.web.app

@ochiu
Copy link
Collaborator

ochiu commented Oct 18, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3079-acknmxx2.web.app

@ochiu
Copy link
Collaborator

ochiu commented Oct 18, 2024

/gcbrun

@rodrigo-barraza
Copy link
Collaborator Author

/gcbrun

Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3079-acknmxx2.web.app

1 similar comment
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-3079-acknmxx2.web.app

@rodrigo-barraza rodrigo-barraza merged commit c6e3692 into bcgov:main Oct 21, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants