Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22579 - Add FED Column & Tooltips (continuation table) #2978

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
09772ea
added Future Effective Date column and date picker
ArwenQin Aug 19, 2024
3994f41
added tooltips to FE date
ArwenQin Aug 19, 2024
cd11158
added hover over text for statuses
ArwenQin Aug 19, 2024
602cc40
added date range truncated and the full text on hover
ArwenQin Aug 19, 2024
bb215d8
added tooltips to NR Date
ArwenQin Aug 20, 2024
92118b3
added drop down menu to actions
ArwenQin Aug 20, 2024
4908972
updated status label naming and table name
ArwenQin Aug 20, 2024
41d9d75
updated daysleft method
ArwenQin Aug 20, 2024
8c2c832
added redirect to nameX
ArwenQin Aug 21, 2024
a0d0e2b
Merge branch 'bcgov:main' into 22579-Add-Column-Continuation-Table
ArwenQin Aug 22, 2024
345c48a
updated redirect to NameX, open in new tab
ArwenQin Aug 22, 2024
8af6076
updated column width
ArwenQin Aug 22, 2024
2d66e35
updated statuses formatting method
ArwenQin Aug 22, 2024
3d173b1
updated FED property name
ArwenQin Aug 22, 2024
84fcda3
fixed the drop down menu bug
ArwenQin Aug 22, 2024
f5c120c
added close icon to other columns
ArwenQin Aug 22, 2024
959c420
calendar icon can open the date picker
ArwenQin Aug 22, 2024
e48da19
status clear icon and clear filters button positioning
ArwenQin Aug 22, 2024
3f9e475
updated daysLeft function
ArwenQin Aug 22, 2024
25c8a9d
Merge branch 'bcgov:main' into 22579-Add-Column-Continuation-Table
ArwenQin Aug 28, 2024
1fe3c70
updated tooltip styles
ArwenQin Aug 28, 2024
4cfcedc
updated the day tooltip wording
ArwenQin Aug 28, 2024
044ae11
FED tooltip possible solution
ArwenQin Aug 28, 2024
d6e09df
FED tooltip styles changed
ArwenQin Aug 28, 2024
0063979
updated package version
ArwenQin Aug 28, 2024
9f0de65
Merge branch 'bcgov:main' into 22579-Add-Column-Continuation-Table
ArwenQin Aug 28, 2024
e422f91
updated package version
ArwenQin Aug 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions auth-web/.env.example
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ VUE_APP_BUSINESS_CREATE_URL="https://dev.create.business.bcregistry.gov.bc.ca/"
VUE_APP_CORPORATE_ONLINE_URL="https://www.corporateonline.gov.bc.ca"
VUE_APP_NRO_URL="https://dev.bcregistrynames.gov.bc.ca/nro/"
VUE_APP_REGISTRY_SEARCH_URL="https://dev.search.business.bcregistry.gov.bc.ca/"
VUE_APP_NAMEX_WEB_URL="https://dev.namex.bcregistry.gov.bc.ca/"

#vaults API
VUE_APP_AUTH_API_URL="https://auth-api-dev.apps.silver.devops.gov.bc.ca"
Expand Down
1 change: 1 addition & 0 deletions auth-web/devops/vaults.env
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ VUE_APP_CORP_FORMS_URL="op://web-url/$APP_ENV/bcregistry/CORP_FORMS_URL"
VUE_APP_LLP_FORMS_URL="op://web-url/$APP_ENV/bcregistry/LLP_FORMS_URL"
VUE_APP_LP_FORMS_URL="op://web-url/$APP_ENV/bcregistry/LP_FORMS_URL"
VUE_APP_XLP_FORMS_URL="op://web-url/$APP_ENV/bcregistry/XLP_FORMS_URL"
VUE_APP_NAMEX_WEB_URL="op://web-url/$APP_ENV/auth-web/NAMEX_WEB_URL"

#vaults API
VUE_APP_AUTH_API_URL="op://API/$APP_ENV/auth-api/AUTH_API_URL"
Expand Down
4 changes: 2 additions & 2 deletions auth-web/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion auth-web/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "auth-web",
"version": "2.6.77",
"version": "2.6.78",
"appName": "Auth Web",
"sbcName": "SBC Common Components",
"private": true,
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
>
<header class="view-header align-center justify-space-between mt-n1 mb-4">
<h2 class="view-header__title">
Continuation Applications
Continuation Authorization Reviews
</h2>
</header>

Expand Down
4 changes: 4 additions & 0 deletions auth-web/src/models/continuation-review.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ export interface ContinuationReviewIF {
results: Array<ContinuationReviewResultIF>
status: ReviewStatus
submissionDate: string // 'YYYY-MM-DDTHH:MM.SS.000+00:00
futureEffectiveDate: string // 'YYYY-MM-DDTHH:MM.SS.000+00:00
nrExpiryDate: string // 'YYYY-MM-DDTHH:MM.SS.000+00:00
}

/** The Continuation In object in the filing API response. */
Expand Down Expand Up @@ -75,6 +77,8 @@ export interface ContinuationFilingIF {
export interface ReviewFilterParams {
startDate?: string // The start date for submission date range
endDate?: string // The end date for submission date range
startEffectiveDate?: string // The start date for future effective date range
endEffectiveDate?: string // The end date for future effective date range
page?: number
limit?: number
nrNumber?: string
Expand Down
4 changes: 4 additions & 0 deletions auth-web/src/util/config-helper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ export default class ConfigHelper {
return `${import.meta.env.VUE_APP_NAME_REQUEST_URL}`
}

static getNameXUrl () {
return `${import.meta.env.VUE_APP_NAMEX_WEB_URL}`
}

static getBceIdOsdLink () {
return `${import.meta.env.VUE_APP_BCEID_OSD_LINK}`
}
Expand Down
6 changes: 6 additions & 0 deletions auth-web/src/util/navigation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ export const goToNameRequest = (nameRequest: NameRequest): void => {
window.location.href = appendAccountId(`${ConfigHelper.getNameRequestUrl()}nr/${nameRequest.id}`)
}

/** Navigation handler for NameX UI. */
export const goToNameXUI = (nrNumber: string): void => {
const cleanedNrNumber = nrNumber.replace(/^NR\s*/, '')
window.open(`${ConfigHelper.getNameXUrl()}examine?nr=${cleanedNrNumber}`)
}

/** Navigation handler for OneStop application */
export const goToOneStop = (): void => {
window.location.href = appendAccountId(ConfigHelper.getOneStopUrl())
Expand Down
Loading