Skip to content

Commit

Permalink
22766 - missed pr feedback (#2984)
Browse files Browse the repository at this point in the history
  • Loading branch information
ochiu authored Aug 28, 2024
1 parent 78d35a0 commit 268f905
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions auth-web/src/components/pay/eft/ShortNameAccountLink.vue
Original file line number Diff line number Diff line change
Expand Up @@ -215,15 +215,14 @@
</template>
<script lang="ts">
import { Ref, computed, defineComponent, reactive, ref, toRefs, watch } from '@vue/composition-api'
import { Ref, computed, defineComponent, nextTick, reactive, ref, toRefs, watch } from '@vue/composition-api'
import { ShortNameLinkStatus, ShortNamePaymentActions } from '@/util/constants'
import { BaseVDataTable } from '@/components'
import CommonUtils from '@/util/common-util'
import { DEFAULT_DATA_OPTIONS } from '@/components/datatable/resources'
import ModalDialog from '@/components/auth/common/ModalDialog.vue'
import PaymentService from '@/services/payment.services'
import ShortNameLinkingDialog from '@/components/pay/eft/ShortNameLinkingDialog.vue'
import { Vue } from 'vue-property-decorator'
import _ from 'lodash'
export default defineComponent({
Expand Down Expand Up @@ -310,7 +309,7 @@ export default defineComponent({
result.statusCode === ShortNameLinkStatus.PENDING && result.amountOwing > 0
)
await Vue.nextTick()
await nextTick()
state.expanded = [...pending]
}
Expand Down
5 changes: 2 additions & 3 deletions auth-web/src/components/pay/eft/ShortNamePaymentHistory.vue
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
</div>
</template>
<script lang="ts">
import { Ref, defineComponent, reactive, ref, toRefs, watch } from '@vue/composition-api'
import { Ref, defineComponent, nextTick, reactive, ref, toRefs, watch } from '@vue/composition-api'
import {
ShortNameHistoryType,
ShortNameHistoryTypeDescription,
Expand All @@ -153,7 +153,6 @@ import { DEFAULT_DATA_OPTIONS } from '../../datatable/resources'
import { EFTTransactionState } from '@/models/eft-transaction'
import ModalDialog from '@/components/auth/common/ModalDialog.vue'
import PaymentService from '@/services/payment.services'
import { Vue } from 'vue-property-decorator'
import _ from 'lodash'
import moment from 'moment-timezone'
Expand Down Expand Up @@ -255,7 +254,7 @@ export default defineComponent({
}
async function scrollToTop () {
await Vue.nextTick()
await nextTick()
if (historyTable.value) {
const tableWrapper = historyTable.value.$el.querySelector('.v-data-table__wrapper')
if (tableWrapper) {
Expand Down

0 comments on commit 268f905

Please sign in to comment.