ORV2-2124 Add PPC_CLERK as allowed auth group to BCeID routes (#1271)

bcgov · Mar 19, 2024 · 5082c69 · 5082c69
1 parent 4741593
commit 5082c69
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 18 deletions.
diff --git a/frontend/package-lock.json b/frontend/package-lock.json
diff --git a/frontend/src/common/authentication/auth-walls/BCeIDAuthWall.tsx b/frontend/src/common/authentication/auth-walls/BCeIDAuthWall.tsx
@@ -24,24 +24,23 @@ export const isIDIR = (identityProvider: string) =>
 
 export const BCeIDAuthWall = ({
   requiredRole,
-  allowedAuthGroups,
+  allowedIDIRAuthGroups,
 }: {
   requiredRole?: UserRolesType;
   /**
    * The collection of auth groups allowed to have access to a page or action.
    * IDIR System Admin is assumed to be allowed regardless of it being passed.
    * If not provided, only a System Admin will be allowed to access.
    */
-  allowedAuthGroups?: IDIRUserAuthGroupType[];
+  allowedIDIRAuthGroups?: IDIRUserAuthGroupType[];
 }) => {
   const {
     isAuthenticated,
     isLoading: isAuthLoading,
     user: userFromToken,
   } = useAuth();
 
-  const { userRoles, companyId, isNewBCeIDUser } =
-    useContext(OnRouteBCContext);
+  const { userRoles, companyId, isNewBCeIDUser } = useContext(OnRouteBCContext);
   const userIDP = userFromToken?.profile?.identity_provider as string;
 
   const location = useLocation();
@@ -77,7 +76,7 @@ export const BCeIDAuthWall = ({
   if (isAuthenticated && isEstablishedUser) {
     if (isIDIR(userIDP)) {
       if (companyId) {
-        return <IDIRAuthWall allowedAuthGroups={allowedAuthGroups} />;
+        return <IDIRAuthWall allowedAuthGroups={allowedIDIRAuthGroups} />;
       } else {
         return (
           <Navigate

diff --git a/frontend/src/routes/Routes.tsx b/frontend/src/routes/Routes.tsx
@@ -142,7 +142,14 @@ export const AppRoutes = () => {
 
       {/* BCeID Routes */}
       {/* Protected Routes */}
-      <Route element={<BCeIDAuthWall requiredRole={ROLES.READ_VEHICLE} />}>
+      <Route
+        element={
+          <BCeIDAuthWall
+            requiredRole={ROLES.READ_VEHICLE}
+            allowedIDIRAuthGroups={[IDIR_USER_AUTH_GROUP.PPC_CLERK]}
+          />
+        }
+      >
         <Route path={routes.VEHICLES_ROUTES.MANAGE}>
           <Route index={true} element={<ManageVehicles />} />
           <Route
@@ -174,14 +181,28 @@ export const AppRoutes = () => {
         </Route>
       </Route>
 
-      <Route element={<BCeIDAuthWall requiredRole={ROLES.READ_ORG} />}>
+      <Route
+        element={
+          <BCeIDAuthWall
+            requiredRole={ROLES.READ_ORG}
+            allowedIDIRAuthGroups={[IDIR_USER_AUTH_GROUP.PPC_CLERK]}
+          />
+        }
+      >
         <Route
           path={routes.PROFILE_ROUTES.MANAGE}
           element={<ManageProfiles />}
         />
       </Route>
 
-      <Route element={<BCeIDAuthWall requiredRole={ROLES.WRITE_USER} />}>
+      <Route
+        element={
+          <BCeIDAuthWall
+            requiredRole={ROLES.WRITE_USER}
+            allowedIDIRAuthGroups={[IDIR_USER_AUTH_GROUP.PPC_CLERK]}
+          />
+        }
+      >
         <Route
           path={routes.PROFILE_ROUTES.ADD_USER}
           element={<AddUserDashboard />}
@@ -192,7 +213,14 @@ export const AppRoutes = () => {
         />
       </Route>
 
-      <Route element={<BCeIDAuthWall requiredRole={ROLES.WRITE_PERMIT} />}>
+      <Route
+        element={
+          <BCeIDAuthWall
+            requiredRole={ROLES.WRITE_PERMIT}
+            allowedIDIRAuthGroups={[IDIR_USER_AUTH_GROUP.PPC_CLERK]}
+          />
+        }
+      >
         <Route
           path={`${routes.APPLICATIONS_ROUTES.START_APPLICATION()}`}
           element={
@@ -202,7 +230,14 @@ export const AppRoutes = () => {
           }
         />
       </Route>
-      <Route element={<BCeIDAuthWall requiredRole={ROLES.WRITE_PERMIT} />}>
+      <Route
+        element={
+          <BCeIDAuthWall
+            requiredRole={ROLES.WRITE_PERMIT}
+            allowedIDIRAuthGroups={[IDIR_USER_AUTH_GROUP.PPC_CLERK]}
+          />
+        }
+      >
         <Route path={routes.APPLICATIONS_ROUTES.BASE}>
           <Route index={true} element={<PermitDashboard />} />
           <Route path={`${routes.APPLICATIONS_ROUTES.DETAILS()}`}>
@@ -234,14 +269,27 @@ export const AppRoutes = () => {
         </Route>
       </Route>
 
-      <Route element={<BCeIDAuthWall requiredRole={ROLES.WRITE_PERMIT} />}>
+      <Route
+        element={
+          <BCeIDAuthWall
+            requiredRole={ROLES.WRITE_PERMIT}
+            allowedIDIRAuthGroups={[IDIR_USER_AUTH_GROUP.PPC_CLERK]}
+          />
+        }
+      >
         <Route
           path={`${routes.PERMITS_ROUTES.SUCCESS()}`}
           element={<SuccessPage />}
         />
       </Route>
 
-      <Route element={<BCeIDAuthWall requiredRole={ROLES.WRITE_PERMIT} />}>
+      <Route
+        element={
+          <BCeIDAuthWall
+            requiredRole={ROLES.WRITE_PERMIT}
+          />
+        }
+      >
         <Route
           path={routes.PAYMENT_ROUTES.PAYMENT_REDIRECT}
           element={<PaymentRedirect />}