Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reviewer actions for nir - srcr exempt #516

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

jaise-aot
Copy link
Contributor

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # SRS-54 - reviewer actions missing in nir form when srcr is exempted.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested NIR form with SRCR exempt. Verified that approve, return and reject buttons are actionable.
  • Tested NIR form with SRCR required. Verified that reviewer actions are not available on NIR form but on SRCR form.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nikhila-aot nikhila-aot merged commit 05cfb3c into dev Sep 26, 2023
11 checks passed
@nikhila-aot nikhila-aot deleted the fix/srs-54-missing-reviewer-actions branch September 26, 2023 17:27
jaise-aot pushed a commit that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants