Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPDDS-281 - Frontend Changes - Do NOT merge until properly tested #465

Merged
merged 10 commits into from
Sep 5, 2023

Conversation

acoard-aot
Copy link
Contributor

@acoard-aot acoard-aot commented Aug 25, 2023

Note

Do NOT merge and deploy this without properly testing it in the test environment. This has been discussed with Nikhila. This PR should be tested in test, then only after it's good merged into dev. It's a little backwards I know. Below are instructions for how to deploy to test without first deploying to dev. I will follow the instructions, but they're left here also in case they're needed again while I'm on holidays.

How to Deploy

Purpose: Deploy Microfrontend code to test ONLY, bypassing dev. However, if/when changes are accepted into dev in the future and merged into dev, this should "just work" and not require any future integration. It should also be able to easily revert if the need arises.

Conceptual explanation:

  1. Change BuildConfigs to use epdds-281 branch
    • forms-flow-theme
    • forms-flow-nav
    • forms-flow-web-ee
  2. Change above BuildConfigs to tag to :test ImageStreamTag
  3. Manually trigger builds for above buildconfigs
  4. Watch as they deploy
  5. Revert steps Add missing topics #2 and Lets use common phrasing #1.
    • Set BuildConfigs to use dev
    • Output to :latest
  6. OPTIONAL > Re-trigger builds and tag them to test if you need to revert the changes in test.

Technical instructions:

# Step 1
oc project e38158-tools
oc patch bc/forms-flow-nav-build -p '{"spec":{"source":{"git":{"ref":"epdds-281"}}}}'
oc patch bc/forms-flow-theme-build -p '{"spec":{"source":{"git":{"ref":"epdds-281"}}}}'
oc patch bc/forms-flow-web-ee-build -p '{"spec":{"source":{"git":{"ref":"epdds-281"}}}}'

# Step 2
oc patch bc/forms-flow-nav-build -p '{"spec":{"output":{"to":{"name":"forms-flow-nav:test"}}}}'
oc patch bc/forms-flow-theme-build -p '{"spec":{"output":{"to":{"name":"forms-flow-theme:test"}}}}'
oc patch bc/forms-flow-web-ee-build -p '{"spec":{"output":{"to":{"name":"forms-flow-web-ee:test"}}}}'

# Step 3
oc start-build bc/forms-flow-nav-build --wait
oc start-build bc/forms-flow-theme-build --wait
oc start-build bc/forms-flow-web-ee-build --wait

# Step 4 - manually watch builds deploy and verify

# Step 5
oc patch bc/forms-flow-nav-build -p '{"spec":{"source":{"git":{"ref":"dev"}}}}'
oc patch bc/forms-flow-theme-build -p '{"spec":{"source":{"git":{"ref":"dev"}}}}'
oc patch bc/forms-flow-web-ee-build -p '{"spec":{"source":{"git":{"ref":"dev"}}}}'

oc patch bc/forms-flow-nav-build -p '{"spec":{"output":{"to":{"name":"forms-flow-nav:latest"}}}}'
oc patch bc/forms-flow-theme-build -p '{"spec":{"output":{"to":{"name":"forms-flow-theme:latest"}}}}'
oc patch bc/forms-flow-web-ee-build -p '{"spec":{"output":{"to":{"name":"forms-flow-web-ee:latest"}}}}'

# Step 5
# Optional, if you need to deploy to test again to basically undo the frontend changes:
oc start-build bc/forms-flow-nav 
oc start-build bc/forms-flow-theme 
oc start-build bc/forms-flow-web-ee-build 

oc tag forms-flow-nav:latest forms-flow-nav:test
oc tag forms-flow-theme:latest forms-flow-theme:test
oc tag forms-flow-web-ee:latest forms-flow-web-ee:test

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nikhila-aot nikhila-aot merged commit cd11430 into dev Sep 5, 2023
11 checks passed
@nikhila-aot nikhila-aot deleted the epdds-281 branch September 5, 2023 17:57
jaise-aot pushed a commit that referenced this pull request Dec 29, 2023
EPDDS-281 - Frontend Changes - Do NOT merge until properly tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants