Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merging dev to main for deployment #439

Merged
merged 50 commits into from
Aug 10, 2023
Merged

merging dev to main for deployment #439

merged 50 commits into from
Aug 10, 2023

Conversation

sakthi-aot
Copy link
Contributor

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

RyanBirtch-aot and others added 30 commits July 28, 2023 13:27
@RyanBirtch-aot
Added disclosure in CSSA, and collection notice in CSSA and SRCR
9e58932
@midhun-aot
hide forms for reviewre
44f1c86
@RyanBirtch-aot
Made changes to non bundled forms
61f8606
@nikhila-aot
Merge pull request #420 from bcgov/cssa-srcr-disclosure-changes
5abc0ca 
Added disclosure in CSSA, and collection notice in CSSA and SRCR
@acoard-aot
Further changes to homepage after discussion with Haley
1a11ecd
@nikhila-aot
Merge pull request #422 from bcgov/haley-homepage-tweak-2
8912629 
Further changes to homepage after discussion with Haley
@nikhila-aot
Merge pull request #421 from bcgov/fix-reviewer-form-access
24aca83 
hide forms for reviewer
@sakthi-aot
Update ff changes to dev-5.2.0 (#407)
bf9249e 
* test imagetsream

* update the formsflow-ai-charts folder with 5.2.0v

* commiting new ff changes

* merge comments resolved

* removing the secrets

* removing the secrets

* removing code owners

* deleting the file
@midhun-aot
added a javascript login to handle approving authority validations
6ec1046
@nikhila-aot
corrected format
03230ed
@nikhila-aot
changes to support form adapter
7765afe
@midhun-aot
updated name for SDS form
d3875b4
@midhun-aot
updated name & path for sds form
cdf5eed
@nikhila-aot
Merge pull request #424 from bcgov/EPDDS-196
58fe40c 
added a javascript logic to handle approving authority validations
@acoard-aot
GitHub Actions for nav/theme/web-ee/root-config
e2946ba
@midhun-aot
Merge pull request #425 from bcgov/feat/task-265a
d9b7bc4 
Feat/task 265a
@midhun-aot
updating notes column width
bd9124d
@RyanBirtch-aot
Added hiding logic for signature field
159f662
@acoard-aot
Configure CI/CD scripts to trigger on temp dev branch to experiment
ce651f3
@acoard-aot
Update CI scripts to trigger build on the script change
fd97144
@acoard-aot
Update namespace env name to use existing secret
a90c884
@acoard-aot
Fix secret -> secrets typo
44323d7
@acoard-aot
Update env setter for non-dev branch during active development
4e5d784
@nikhila-aot
Merge pull request #426 from bcgov/EPDDS-241
2109321 
updating notes columns width and adding work break
@midhun-aot
fixed site owner actons and notes section displayed for new forms
7757362
@acoard-aot
Fix env var for nav/theme/ee for non dev branch
d615ab8
@acoard-aot
Merge pull request #429 from bcgov/epdds-270
c0f428d 
CI/CD of microfrontends nav/theme/web-ee/root-config
@nikhila-aot
Merge pull request #428 from bcgov/epd-237
9a02be0 
fixed site owner actons and notes section displayed for new forms
@RyanBirtch-aot
Matched names
2008f73
@nikhila-aot
Merge pull request #427 from bcgov/203-signature-hiding
fccbb01 
Added hiding logic for signature field in sds form
nikhila-aot and others added 15 commits August 3, 2023 12:28
@nikhila-aot
Merge pull request #431 from bcgov/remove-console-log
b2a8197 
Remove console log statements
@nikhila-aot
changes for single form in bundle
a11a331
@nikhila-aot
support for single form bundle
ab32329
@nikhila-aot
issue fixes in flow
389f56d
@nikhila-aot
changes for handling single form
35b95fc
@midhun-aot
Merge pull request #433 from bcgov/task/feat-239
af1864d 
Task/feat 239
@midhun-aot
updated npm map package
8027318
@midhun-aot
add map-package-code-changes
4313711
@nikhila-aot
Merge pull request #434 from bcgov/update-map-package
3d3da67 
Updating map package
@midhun-aot
updating bc fav icon
92df62f
@nikhila-aot
Merge pull request #435 from bcgov/update-fav-icon
c0cd54e 
updating bc fav icon
@midhun-aot
updating site title
07d2327
@nikhila-aot
Merge pull request #436 from bcgov/update-fav-icon
74333eb 
updating site title
@nikhila-aot
Feat/task 266 (#437)
c8884a1 
* initial changes for SDS

* corrected form to have new buttons and validation
@nikhila-aot
email id issue fix (#438)
0ce877a
@sakthi-aot sakthi-aot temporarily deployed to dev August 10, 2023 15:04 — with GitHub Actions Inactive
@sakthi-aot sakthi-aot temporarily deployed to dev August 10, 2023 15:04 — with GitHub Actions Inactive
@sakthi-aot sakthi-aot temporarily deployed to dev August 10, 2023 15:04 — with GitHub Actions Inactive
@sakthi-aot sakthi-aot temporarily deployed to dev August 10, 2023 15:04 — with GitHub Actions Inactive
@sakthi-aot sakthi-aot temporarily deployed to dev August 10, 2023 15:04 — with GitHub Actions Inactive
@sakthi-aot sakthi-aot temporarily deployed to dev August 10, 2023 15:04 — with GitHub Actions Inactive
acoard-aot
acoard-aot approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@acoard-aot acoard-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. GitHub Actions for the microfrontends will need to be modified after 270 is completed, but this is fine for now.

@nikhila-aot nikhila-aot merged commit 6daf063 into main Aug 10, 2023
40 of 41 checks passed
jaise-aot pushed a commit that referenced this pull request Dec 29, 2023
@nikhila-aot
Merge pull request #439 from bcgov/dev
ecba902 
merging dev to main for deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhila-aot nikhila-aot nikhila-aot approved these changes

@acoard-aot acoard-aot acoard-aot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sakthi-aot @nikhila-aot @acoard-aot @RyanBirtch-aot @midhun-aot