-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
23572 update dissolution letters #3023
Merged
kzdev420
merged 2 commits into
bcgov:main
from
kzdev420:23572_update_dissolution_letters
Oct 16, 2024
Merged
23572 update dissolution letters #3023
kzdev420
merged 2 commits into
bcgov:main
from
kzdev420:23572_update_dissolution_letters
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzdev420
requested review from
chenhongjing,
argush3,
leodube-aot,
eason-pan-bc and
AimeeGao
and removed request for
argush3
October 9, 2024 19:39
legal-api/report-templates/noticeOfDissolutionCommencement.html
Outdated
Show resolved
Hide resolved
AimeeGao
reviewed
Oct 10, 2024
AimeeGao
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🚀
Quality Gate failedFailed conditions |
eason-pan-bc
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
chenhongjing
added a commit
that referenced
this pull request
Oct 22, 2024
* 23348 - Add allowable actions for notice of withdrawal (#3014) * Add notice of withdrawal for existing business * 23349 - validation notice of withdrawal (#3020) * implement validation logic for NoW * update schema version number in requirements * exclude the new business scenario * 23539 add batch_processing to colin_event_ids table (#3021) * 23539 add batch_processing to colin_event_ids table * add relationship, tests * fix downgrade issue * remove re-define batch_processing_step enum * 23608 - Update furnishing entries transferred to bc mail+ (#3025) * Fix bug * 23697 - fix stage1 to stage2 dissolution transition bug (#3028) * add SFTP off feature flag, modify stage 2 furnishing entry check, update tests * adjust mail status check when FF is on * add feature flag "disable-dissolution-sftp-bclaws" * refactor stage 1 furnishing entries check * update tests * 23522-23562 continuation in workflow change (#3026) * 23572 update dissolution letters (#3023) * 23572 update dissolution letters * add the dots * 23845 - Bumped version numbers up for release 23.2a (#3030) * bump version * update entity-bn version * udpate version * 23563 - update review endpoint (#3029) * 23563 - update review endpoint * 23563 - update api spec * 23563 - update api spec filing description * Undo colin_event_id model changes (#3032) --------- Co-authored-by: Aimee <[email protected]> Co-authored-by: EasonPan <[email protected]> Co-authored-by: Kevin Zhang <[email protected]> Co-authored-by: Vysakh Menon <[email protected]> Co-authored-by: ketaki-deodhar <[email protected]> Co-authored-by: leodube-aot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#23572
Description of changes:
BC-Corp.pdf
PRTA.pdf
XPRO.pdf
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).