Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23572 update dissolution letters #3023

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

kzdev420
Copy link
Collaborator

@kzdev420 kzdev420 commented Oct 9, 2024

Issue #: /bcgov/entity#23572

Description of changes:
BC-Corp.pdf
PRTA.pdf
XPRO.pdf

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@kzdev420 kzdev420 self-assigned this Oct 9, 2024
@kzdev420 kzdev420 requested review from chenhongjing, argush3, leodube-aot, eason-pan-bc and AimeeGao and removed request for argush3 October 9, 2024 19:39
Copy link
Collaborator

@AimeeGao AimeeGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
100.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@eason-pan-bc eason-pan-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kzdev420 kzdev420 merged commit e0fd7a9 into bcgov:main Oct 16, 2024
10 of 11 checks passed
chenhongjing added a commit that referenced this pull request Oct 22, 2024
* 23348 - Add allowable actions for notice of withdrawal (#3014)

* Add notice of withdrawal for existing business

* 23349 - validation notice of withdrawal (#3020)

* implement validation logic for NoW
* update schema version number in requirements
* exclude the new business scenario

* 23539 add batch_processing to colin_event_ids table (#3021)

* 23539 add batch_processing to colin_event_ids table

* add relationship, tests

* fix downgrade issue

* remove re-define batch_processing_step enum

* 23608 - Update furnishing entries transferred to bc mail+ (#3025)

* Fix bug

* 23697 - fix stage1 to stage2 dissolution transition bug (#3028)

* add SFTP off feature flag, modify stage 2 furnishing entry check, update tests
* adjust mail status check when FF is on
* add feature flag "disable-dissolution-sftp-bclaws"
* refactor stage 1 furnishing entries check
* update tests

* 23522-23562 continuation in workflow change (#3026)

* 23572 update dissolution letters (#3023)

* 23572 update dissolution letters

* add the dots

* 23845 - Bumped version numbers up for release 23.2a (#3030)

* bump version

* update entity-bn version

* udpate version

* 23563 - update review endpoint (#3029)

* 23563 - update review endpoint

* 23563 - update api spec

* 23563 - update api spec filing description

* Undo colin_event_id model changes (#3032)

---------

Co-authored-by: Aimee <[email protected]>
Co-authored-by: EasonPan <[email protected]>
Co-authored-by: Kevin Zhang <[email protected]>
Co-authored-by: Vysakh Menon <[email protected]>
Co-authored-by: ketaki-deodhar <[email protected]>
Co-authored-by: leodube-aot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants