21515 - MRAS & BN emails for continuation in and amalgamation #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketaki-deodhar
commented
Sep 5, 2024
| @@ -121,14 +122,16 @@ def subscription_options(): | |||
| identifier = arg | |||
| elif opt in ('-n', '--name'): | |||
| name = arg | |||
| if not etype or (etype not in [affiliation_type, dissolution_type] and not all([fid, etype, option])): | |||
| if not etype or (etype not in [affiliation_type, dissolution_type, bn] and not all([fid, etype, option])): | |||
There was a problem hiding this comment.
I had to add check for 'bn' here otherwise it would exit right away
queue_services/entity-emailer/src/entity_emailer/email_processors/bn_notification.py
Outdated
Show resolved
Hide resolved
|
vysakh-menon-aot
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#21515
Description of changes:
Some other unit tests are failing but the ones I added are running locally:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).