22353 correction of C, CBEN, CCC, CUL #2943
Conversation
| @@ -133,7 +133,11 @@ def validate_roles(filing_dict: dict, legal_type: str, filing_type: str = 'incor | |||
| Business.LegalTypes.BCOMP.value: 1, | |||
| Business.LegalTypes.COMP.value: 1, | |||
| Business.LegalTypes.BC_ULC_COMPANY.value: 1, | |||
| Business.LegalTypes.BC_CCC.value: 3 | |||
| Business.LegalTypes.BC_CCC.value: 3, | |||
There was a problem hiding this comment.
This func is used in correction
| @@ -47,9 +47,7 @@ def process(correction_filing: Filing, filing: Dict, filing_meta: FilingMeta, bu | |||
| ) | |||
|
|
|||
| corrected_filing_type = filing['correction']['correctedFilingType'] | |||
| # added CP, change of directors / change of address for CP is allowed | |||
| if business.legal_type in ['SP', 'GP', 'BC', 'BEN', 'CC', 'ULC', 'CP'] and \ | |||
There was a problem hiding this comment.
unnecessary if condition, this contains all legal types
There was a problem hiding this comment.
What if we add new legal types?
There was a problem hiding this comment.
it should be handled in allowable actions
queue_services/entity-filer/src/entity_filer/filing_processors/correction.py
Show resolved
Hide resolved
|
vysakh-menon-aot
requested review from
ketaki-deodhar,
argush3 and
severinbeauvais
|
@argush3 I looked into the |
yeah, it's here https://app.zenhub.com/workspaces/entities---david-65af11a89e89f5043c2911f6/issues/gh/bcgov/entity/22367 |
| @@ -422,66 +422,6 @@ async def test_process_filing_completed(app, session, mocker): | |||
| assert business.last_ar_date | |||
|
|
|||
|
|
|||
| async def test_correction_filing(app, session, mocker): | |||
There was a problem hiding this comment.
not valid anymore. CP will not go to PENDING_CORRECTION status
There was a problem hiding this comment.
That status was for "local corrections", right?
Yes, local corrections are removed from UI code. The only possibility is something like a conversion correction (as above), but even that's not allowed, I think.
Issue #: /bcgov/entity#22353
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).