Api spec updates #2933
Merged
Api spec updates #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add AGM_location_change schema * update filing_head schema * update Filing schema * update business schema * add example - agm location change to the filing path * add 3 failed response examples - missing location, reason, year
* Update consent continuation out filing doc
* Update related schemas for voluntary dissolution * update examples names in agm location change to follow naming convensions, update submiter and payment info to mocks * add request and response examples for voluntary dissolution * update example info for get the certificate of good standing * remove all taxId fields in x-examples under Party and Officer/Person
* 22114 - add change of address api specs * 22114 - update request and response * 22114 - revert changes for actions * 22114 - update names and objects * 22114 - update as per naming convention and responses * 22114 - update response name
* Update Agm extension schema and spec.
* Updated relevant schemas -- Annual_report, office * Added request and response examples for annual report filing
* 22211 - add amalgamation spec * 22211 - update response name * 22211 - updates * 22211 - updates * 22211 - updates * 22211 - updates * 22211 - updates * 22211 - updates * 22211 - updates
* Update change of directors spec
* update relevant schemas (name_request, name_translation, court_order) * add request and response examples for alterations
Add OAS CI workflow to api-spec-updates branch for docs/business.yaml file so any updates to api spec are linted.
- moved business.yaml under docs/oas/ - updated the file path in oas-ci - Will have a test PR after this PR merged. Try to see if this change can make the lint check work properly.
add permissions section
* incorporation application changes for api spec * removed id from request body * replaced date and nrnum * replaced account id with mock val * fixed indent * added 401 unauthorized response * changed date string types and values
… to the latest oas-ci changes (#2888) * updated the oas ci file based on suggestions from Patrick Wei * moved the business.yaml to ./docs, since the oas ci in SRE repo has now changed
Adjust wording for POST /businesses/{identifier}/filings endpoint
Update wording for GET /businesses/{identifier}/filings endpoint
…cumentName} (#2910) Update wording for GET /businesses/{identifier}/documents/{documentName} endpoint
* adjust wordings based on the feedback doc and discussion for business overview section and related items
…2917) Sorted filing request and response examples alphabetically for POST /businesses/{identifier}/filings
* update spec wording * fix duplicate issue
* removed the duplications in the enums * adjusted the required item in the Filing schema to filing which is the one in Business Schemas * adjusted filing_header schema to fit the updated filing schema * adjusted examples didn't meet requirements in schemas
* update spec wording * fix duplicate issue * arrange in alphabetical order * fix lint issue
* update spec wording * fix duplicate issue * arrange in alphabetical order * fix lint issue * fix linting issue 1 * fix linting issue 1 * fix linting issue 2 * fix linting issue 3 * fix linting issue 4
|
AimeeGao
approved these changes
Aug 20, 2024
ketaki-deodhar
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#22879
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).