-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22496 Emailer - stage 1 overdue ARs notification (EP flow) #2924
Conversation
Signed-off-by: Hongjing Chen <[email protected]>
Quality Gate passedIssues Measures |
</ul> | ||
|
||
[[whitespace-16px.html]] | ||
[[business-dashboard-link.html]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the design and it doesn't have this information so I delete it.
{% if furnishing_name == 'DISSOLUTION_COMMENCEMENT_NO_AR_XPRO' %} | ||
a delay of the cancellation process. | ||
{% elif extra_provincials %} | ||
a delay of the dissolution or cancellation process. | ||
{% else %} | ||
a delay of the dissolution process. | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous work was done improperly at this part. The wordings in design are different for BC companies with EP registration, BC companies without EP registration, and extraprovincial companies.
[Furnishing.FurnishingName.DISSOLUTION_COMMENCEMENT_NO_AR_XPRO, | ||
Furnishing.FurnishingName.DISSOLUTION_COMMENCEMENT_NO_TR_XPRO]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming extraprovincial companies won't have EP registrations. Let me know if I'm wrong. 💭 And we don't have transition scenario for Xpro for now, but I add it in case we need it. Will change it if not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think transition filing is required for EPs.
https://www.corporateonline.gov.bc.ca/WebHelp/faq.htm
You can also confirm with Dylan if you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized I added that as a furnishing_name
in furnishings
table...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, nope, confirmed with Dylan 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Issue #: /bcgov/entity#22496
Description of changes:
Local Testing
The testing result can be found at MailHog for A0883551 (I created this and it can be also found in dev. However, auth-api and UI don't fully support this type of business)
Unit Test
The related tests are passed. And the other broken tests will be fixed in another work.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).