Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update continuation in spec #2872

Closed

Conversation

ketaki-deodhar
Copy link
Collaborator

@ketaki-deodhar ketaki-deodhar commented Jul 30, 2024

Issue #: /bcgov/entity#22212

Description of changes:

Postman collection:

image

image

image

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@ketaki-deodhar ketaki-deodhar self-assigned this Jul 30, 2024
@ketaki-deodhar ketaki-deodhar marked this pull request as ready for review July 30, 2024 22:56
errorMessage: API backend third party service error.
rootCause: message:You are not authorized to submit a filing for TgtPxoS4FF.
registration-unauthorized-response:
summary: Registration - Not Authorized To Submit Response
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restructuring this in alphabetical order is a good idea 👍

docs/oas/business.yaml Outdated Show resolved Hide resolved
filing:
continuationIn:
authorization:
date: '2024-07-01'
Copy link
Collaborator Author

@ketaki-deodhar ketaki-deodhar Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vysakh-menon-aot File upload example below

name: continuationIn
continuationIn:
authorization:
date: '2024-07-01'
Copy link
Collaborator Author

@ketaki-deodhar ketaki-deodhar Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vysakh-menon-aot File upload request example

Comment on lines 2693 to 2696
- file:
lastModified: 1667594705083
name: TestPDFfile.pdf
size: 83186
Copy link
Collaborator

@vysakh-menon-aot vysakh-menon-aot Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required (only fileKey and fileName are required)

Copy link
Contributor

@PaulGarewal PaulGarewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the minio file upload section is correct

Copy link
Collaborator

@eason-pan-bc eason-pan-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that in the Postman collection, id is still there under officer in the request body and response. Consider updating them.
image

docs/oas/business.yaml Outdated Show resolved Hide resolved
docs/oas/business.yaml Outdated Show resolved Hide resolved
docs/oas/business.yaml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 1, 2024

Copy link
Collaborator

@eason-pan-bc eason-pan-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec updates LGTM

@ketaki-deodhar
Copy link
Collaborator Author

Closing this PR as conflicts got a bit messy. Will create PR with all the changes

@ketaki-deodhar ketaki-deodhar deleted the update-cont-in-spec branch August 23, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants