Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21768 Emailer - stage 1 overdue transition notification #2867

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

leodube-aot
Copy link
Collaborator

@leodube-aot leodube-aot commented Jul 30, 2024

Issue #: /bcgov/entity#21768

Description of changes:

  • Updated the email template for overdue transition notification
  • Failed unit tests are unrelated to these changes

Output from running locally
Screenshot 2024-07-30 at 6 27 25 AM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@leodube-aot leodube-aot self-assigned this Jul 30, 2024
@argush3
Copy link
Collaborator

argush3 commented Jul 31, 2024

looks good. can we add a test for this scenario to here?

('f36e3af7-90c3-4859-a6f6-2feefbdc1e30',
{
'specversion': '1.x-wip',
'type': 'bc.registry.dissolution',
'source': 'furnishingsJob',
'id': 'f36e3af7-90c3-4859-a6f6-2feefbdc1e30',
'time': '',
'datacontenttype': 'application/json',
'identifier': 'BC123223',
'data': {
'furnishing': {
'type': 'INVOLUNTARY_DISSOLUTION',
'furnishingId': 1,
'furnishingName': 'DISSOLUTION_COMMENCEMENT_NO_AR'
}
}
}),

i.e. furnishing_name = "DISSOLUTION_COMMENCEMENT_NO_TR"

Copy link

sonarcloud bot commented Jul 31, 2024

@leodube-aot leodube-aot merged commit 9dd9643 into bcgov:main Jul 31, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants