Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21475 Filer - Fix target dissolution date calculation #2788

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

chenhongjing
Copy link
Collaborator

Issue #: /bcgov/entity#21475

Description of changes:

  • Fix wrong calculation for target dissolution date

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@chenhongjing chenhongjing self-assigned this Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.65%. Comparing base (81aac8e) to head (a7ab396).
Report is 180 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2788      +/-   ##
==========================================
+ Coverage   75.49%   81.65%   +6.15%     
==========================================
  Files         196       42     -154     
  Lines       12264     1924   -10340     
  Branches     2054      353    -1701     
==========================================
- Hits         9259     1571    -7688     
+ Misses       2442      197    -2245     
+ Partials      563      156     -407     
Flag Coverage Δ
entityemailer ?
entityfiler 81.65% <100.00%> (?)
legalapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ntity_filer/filing_processors/change_of_address.py 100.00% <100.00%> (ø)

... and 237 files with indirect coverage changes

@chenhongjing chenhongjing merged commit 9f26690 into bcgov:main Jun 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants