21475 Filer - Update Change of Address filing processor to delay dissolution #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Local testing results
There are only two failed tests.
|
chenhongjing
requested review from
argush3,
kzdev420,
vysakh-menon-aot and
leodube-aot
leodube-aot
approved these changes
Jun 11, 2024
| if flag_on: | ||
| if business.in_dissolution: | ||
| batch_processinges = BatchProcessing.find_by(business_id=business.id) | ||
| for batch_processing in batch_processinges: |
There was a problem hiding this comment.
Plural would be batch_processings
|
argush3
reviewed
Jun 13, 2024
queue_services/entity-filer/src/entity_filer/filing_processors/change_of_address.py
Outdated
Show resolved
Hide resolved
chenhongjing
force-pushed
the
21475-filer
branch
from
1d5c209
to
4198c46
Compare
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
…date more than 60 days Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
chenhongjing
force-pushed
the
21475-filer
branch
from
440b684
to
9de4ffd
Compare
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2750 +/- ##
==========================================
+ Coverage 75.49% 81.54% +6.04%
==========================================
Files 196 42 -154
Lines 12264 1913 -10351
Branches 2054 351 -1703
==========================================
- Hits 9259 1560 -7699
+ Misses 2442 197 -2245
+ Partials 563 156 -407
Flags with carried forward coverage won't be shown. Click here to find out more.
|
argush3
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#21475
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).