Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20359 -business summary updates #2593

Merged
merged 6 commits into from
Apr 16, 2024
Merged

20359 -business summary updates #2593

merged 6 commits into from
Apr 16, 2024

Conversation

ketaki-deodhar
Copy link
Collaborator

@ketaki-deodhar ketaki-deodhar commented Apr 16, 2024

Issue #: /bcgov/entity#20359

Description of changes:

  • updated business summary to use alternate name
  • adjusted functions to handle other alternate name updates

Examples:

FM1000001:

Local:
image
image

OCP Dev:

FM1000001.Summary.-.2024-04-06.pdf

FM0292609:

  • partner information issue here

Local:

responseCol

OCP Dev:

FM0292609 Summary - 2024-04-09

FM1000051:

  • partner information issue here

Local:

response2

OCP Dev:

FM1000051 Summary - 2024-04-06
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@ketaki-deodhar ketaki-deodhar marked this pull request as ready for review April 16, 2024 17:24
@ketaki-deodhar ketaki-deodhar self-assigned this Apr 16, 2024
@argush3
Copy link
Collaborator

argush3 commented Apr 16, 2024

There are still issues with SP DBA person and possibly other firms I think. When I tested FM0554225(SP DBA person), there was an issue in set_description and various issues in set_dates.

But I think we can just cut another ticket and re-visit it when we get back to this work.

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

argush3
argush3 approved these changes Apr 16, 2024
@ketaki-deodhar ketaki-deodhar merged commit 49ee907 into bcgov:feature-legal-name Apr 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants