20359 Initial business summary updates #2575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulGarewal
commented
Apr 9, 2024
| business_json["business"]["businessName"] = self._legal_entity.alternate_names[0].name | ||
| else: | ||
| business_json["business"]["businessName"] = self._legal_entity.business_name | ||
|
|
There was a problem hiding this comment.
may be better logic here for alternate names.
PaulGarewal
commented
Apr 9, 2024
| @@ -303,6 +307,8 @@ def _set_parties(self, legal_entity: dict): | |||
| party["mailingAddress"] = BusinessDocument._format_address(party["mailingAddress"]) | |||
| if party.get("deliveryAddress"): | |||
| party["deliveryAddress"] = BusinessDocument._format_address(party["deliveryAddress"]) | |||
| if not party.get("officer", {}).get("partyType") and not party.get("officer", {}).get("lastName"): | |||
| party["officer"]["partyType"] = "organization" | |||
| legal_entity["parties"] = party_json | |||
There was a problem hiding this comment.
handles an odd case when the partner of a firm is an organization, partyType will not be populated. Does not handle when there are 2 partner organizations yet.
Example in FM1000051
My initial changes were getting out of hand to handle this fully, so looking for cleaner suggestions.
PaulGarewal
commented
Apr 9, 2024
| if self._legal_entity.alternate_names and self._legal_entity.legal_name == None: | ||
| legal_entity["meta_subject"] = "{} ({})".format(self._legal_entity.alternate_names[0].name, self._legal_entity.identifier) | ||
| else: | ||
| legal_entity["meta_subject"] = "{} ({})".format(self._legal_entity.legal_name, self._legal_entity.identifier) | ||
|
|
There was a problem hiding this comment.
Kept getting an error here when the conditional was met, handles that case but needs improvement.
PaulGarewal
requested review from
ketaki-deodhar,
argush3,
vysakh-menon-aot,
JazzarKarim and
tshyun24
|
There's a linting issue Paul. |
PaulGarewal
force-pushed
the
20359-business-summary-update
branch
from
811327e
to
1c1f56a
Compare
|
|
Ketaki will be taking over this ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#20359
Description of changes:
Examples:
FM1000001:
Local:
OCP Dev:
FM1000001.Summary.-.2024-04-06.pdf
FM0292609:
Local:
OCP Dev:
FM1000051:
Local:
OCP Dev:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).