20362 - Filing outputs #2564
Merged
20362 - Filing outputs #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketaki-deodhar
commented
Apr 3, 2024
|
|
||
| if business.is_legal_entity and business.tax_id: | ||
| business_number = business.tax_id | ||
|
|
There was a problem hiding this comment.
To handle tax_id and bn15 for both
ketaki-deodhar
commented
Apr 3, 2024
legal-api/tests/unit/resources/v2/test_business_filings/test_filings.py
Outdated
Show resolved
Hide resolved
argush3
reviewed
Apr 8, 2024
argush3
reviewed
Apr 8, 2024
argush3
reviewed
Apr 8, 2024
vysakh-menon-aot
approved these changes
Apr 11, 2024
|
argush3
approved these changes
Apr 11, 2024
ketaki-deodhar
merged commit 2eb37d0
into
bcgov:feature-legal-name
4 of 5 checks passed
PaulGarewal
pushed a commit
to PaulGarewal/lear
that referenced
this pull request
Apr 12, 2024
* 20362-Filing outputs * 20362-fix formatting issue * 20362-fix flake 8 issue * 20362-fix header for dissolution statement * 20362-fixes after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#20362
Description of changes:
update filing outputs to work with alternate names
Some samples:
This is for SP:
DEV link to compare: https://dev.business.bcregistry.gov.bc.ca/FM1000050
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).