Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19314 - update CI for BE jobs #2421

Merged
merged 20 commits into from
Feb 1, 2024
Merged

Conversation

tshyun24
Copy link
Contributor

@tshyun24 tshyun24 commented Jan 29, 2024

Issue #: /bcgov/entity#19314

Description of changes:

  • email reminder
  • future effective filings
  • update colin filings
  • update legal filings

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@tshyun24 tshyun24 self-assigned this Jan 29, 2024
@tshyun24 tshyun24 changed the title update email reminder ci test update email reminder ci Jan 29, 2024
@tshyun24 tshyun24 changed the title test update email reminder ci 19314 - test update email reminder ci Jan 30, 2024
@tshyun24 tshyun24 marked this pull request as draft January 30, 2024 20:31
@tshyun24 tshyun24 changed the title 19314 - test update email reminder ci 19314 - update CI for BE jobs Jan 31, 2024
@tshyun24 tshyun24 marked this pull request as ready for review January 31, 2024 19:01
@tshyun24 tshyun24 marked this pull request as draft January 31, 2024 19:03
@argush3
Copy link
Collaborator

argush3 commented Jan 31, 2024

As per our conversation, @pwei1018 will be creating a separate SRE shared workflow for jobs that you can reference in each jobs ci workflow file.

And we will need to add a tests folder to each job.

@tshyun24 tshyun24 requested a review from argush3 February 1, 2024 00:35
@tshyun24 tshyun24 marked this pull request as ready for review February 1, 2024 00:35
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tshyun24 tshyun24 merged commit a822f82 into bcgov:feature-legal-name Feb 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants